What am I doing?
Reviewed a pull request in linkrobins/support · GitHub
refactor: modernize frontend structure to Flarum 2.x extender conventions and strict typingThanks, this is a clean refactor and it behaved identically in our testing. One change before we merge: the new tsconfig undoes the TypeScript 7 setup from 50.…
Commented in linkrobins/clipboard · GitHub
Issue copy plain codeThanks for the report. This turned out to be a Flarum core bug: the emoji extension turns emoji inside code into images, and the code highlighter then drops…
Commented in linkrobins/clipboard · GitHub
Copy emoji in code blocksClosing in favor of the core fix: flarum/framework5345 keeps emoji in code as plain text, so the copy button gets them without any change here.
Opened a pull request in flarum/framework · GitHub
[2.x] fix(emoji): keep emoji in code as plain textProblem
Opened a pull request in linkrobins/clipboard · GitHub
Copy emoji in code blocksThe copy button dropped emoji from code blocks.
Opened a pull request in flarum/framework · GitHub
[2.x] fix(a11y): make the post author name a second level headingWhat's wrong
Opened a pull request in flarum/framework · GitHub
[2.x] fix(a11y): hide the redundant post avatar link from assistive techWhat's wrong
Opened a pull request in flarum/framework · GitHub
[2.x] fix(a11y): keep the post stream feed's children articlesWhat's wrong
Opened a pull request in flarum/framework · GitHub
[2.x] fix(core): mark error pages as guest-user or logged-inWhat's wrong
Opened a pull request in flarum/framework · GitHub
[2.x] fix(a11y): include the visible label in a dropdown toggle's accessible nameWhat's wrong
Opened an issue in flarum/framework · GitHub
[2.x] bbcode: highlight.js loader runs once per code block and adds ~1.1 s TBT on mobileOn any discussion with code blocks, the bbcode extension's CODE template makes the browser load s9e/hljs-loader from cdn.jsdelivr.net, and running that loader…
Opened an issue in FriendsOfFlarum/upload · GitHub
[2.x] Image Preview uses loading="lazy" on the LCP image, delaying LCPThe Image Preview template renders every image with loading="lazy" (resources/templates/image-preview.blade.php). When the first image in a post is also the…
Replied in · discuss.flarum.org
Logged In / Guest status on 404 PageMorgan I appreciate that. I can prepare a PR just for this and tag Ian and see where it goes from there 🙂
Replied in · discuss.flarum.org
Logged In / Guest status on 404 PageMorgan this is exactly why I built the login for my support extension. I think this would be a good thing to be resolved via Core, but it's ultimately @IanM…
Pushed 2 commits to linkrobins/flarum-wiki · GitHub
linkrobins/flarum-wikiKeep the article list working when an article's stored content is malformed (44)
Opened a pull request in linkrobins/flarum-wiki · GitHub
Keep the article list working when an article's stored content is malformedWhat broke: WikiArticle::excerpt() passed the stored parsedcontent straight to removeFormatting().
Pushed 1 commit to linkrobins/support · GitHub
linkrobins/supportGuests who tap New ticket get the log-in modal (56)
Opened a pull request in linkrobins/support · GitHub
Guests who tap New ticket get the log-in modalFollows Flarum's own pattern for logged-out visitors: a guest who tries an action that needs an account gets the log-in modal right away, and after logging in…
Replied in · discuss.flarum.org
Link Robins Support — Private support ticketsv1.13.2 — Fixes the Log In and Sign Up buttons on the support desk's sign-in prompt. Fixed The sign-in prompt's buttons work. In 1.13.1, a visitor who wasn't…